Forbid cached thread pools#14336
Closed
jasontedor wants to merge 1 commit intoelastic:masterfrom
jasontedor:forbid-cached-thread-pools
Closed
Forbid cached thread pools#14336jasontedor wants to merge 1 commit intoelastic:masterfrom jasontedor:forbid-cached-thread-pools
jasontedor wants to merge 1 commit intoelastic:masterfrom
jasontedor:forbid-cached-thread-pools
Conversation
Member
Author
|
@kimchy Would you mind opining on whether or not you think this is okay to forbid? |
Contributor
|
This sounds reasonable to me. The PR is only tagged with 3.0 for now but if we decide to merge it I think it would make sense to have it on 2.x as well (I wouldn't consider it a breaking change as this is a very expert setting). |
Member
Author
|
Closing in favor of #14367 which takes this pull request further by forbidding changing the thread pool type for any thread pool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit forbids the “cached” thread pool setting for any thread
pool other than the generic thread pool (which we continue to require
to be of type “cached”).
Closes #14294, relates #2858, relates #5152